-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kuma-cp): consumer policies on app's namespace #10361
Merged
lobkovilya
merged 8 commits into
kumahq:master
from
lobkovilya:feat/consumer-policies-on-namespace
Jun 10, 2024
Merged
feat(kuma-cp): consumer policies on app's namespace #10361
lobkovilya
merged 8 commits into
kumahq:master
from
lobkovilya:feat/consumer-policies-on-namespace
Jun 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
…ateway and MeshService in to[] Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
lobkovilya
requested review from
jakubdyszkiewicz,
Automaat and
lukidzi
and removed request for
a team
June 5, 2024 11:56
Icarus9913
reviewed
Jun 6, 2024
Automaat
reviewed
Jun 6, 2024
Automaat
approved these changes
Jun 6, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR partially implements madr-52 and allows applying policies on the custom namespace.
Based on how policy looks Kuma CP adds a new label:
Producer policies are not supported at this moment, because we can't reference
MeshService
into[].targetRef.kind
.Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --